Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: Craft isn't picking up the Chinese translation file #14287

Closed
angrybrad opened this issue Feb 5, 2024 · 2 comments
Closed

[4.x]: Craft isn't picking up the Chinese translation file #14287

angrybrad opened this issue Feb 5, 2024 · 2 comments
Assignees

Comments

@angrybrad
Copy link
Member

What happened?

Description

On a fresh Craft 4 install, if you select Chinese (zh) as the site language, the Craft control panel does not appear to pick up the translation file, but every other language works.

Steps to reproduce

  1. Make a fresh install of Craft 4.
  2. During installation, select “Chinese” as the system language.
  3. Finish install.
  4. Swap to Craft Pro.
  5. Click Users => New User
  6. Without filling anything in, click the save user button
  7. Notice most of the validation error is in English.

CleanShot 2024-02-04 at 21 48 37@2x

Repeat the same steps, but select “French” during installation, and you get the fully translated validation message.

CleanShot 2024-02-04 at 21 52 04@2x

Craft CMS version

4.7.1

PHP version

8.2

Operating system and version

n/a

Database type and version

MySQL 8

Image driver and version

n/a

Installed plugins and versions

None

@i-just
Copy link
Contributor

i-just commented Feb 5, 2024

It looks like Yii moved their translation file from zh-CN to plain zh, which means we should no longer adjust the language id mapping for Chinese. PR raised.

@brandonkelly
Copy link
Member

Fixed in 4.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants