Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEditor field accessible name doesn't match visible label, and lacks contextual info #74

Closed
gcamacho079 opened this issue Apr 18, 2023 · 2 comments
Assignees

Comments

@gcamacho079
Copy link

Description

See title

Steps to reproduce

  1. Create a new custom field using the CKEditor field type, and add Default Instructions
  2. Add the custom field to a field layout
  3. Go to the Edit page and inspect accessibility properties: regardless of the field name, the .ck-editor__editable element has the accessible name “Editor editing area: main” and doesn’t reference instructions, errors, etc., as other fields do.

Expected behavior

  • The accessible name of the field should include the visible field name, preferably at the beginning. For example, if the field name is “Post Content,” the accessible name can be “Post Content, Editor editing area: main.”
  • Additional information, like errors and instructions, should be referenced using aria-describedby

Additional info

  • Craft version: 4.4.7
  • PHP version: 8.0.21
  • Database driver & version: MariaDB 10.4.25
  • Plugins & versions: 3.0.0
@i-just
Copy link
Contributor

i-just commented Feb 13, 2024

Hi Lupe!

I raised a PR to do this. It’s only possible to change those once the editor is instantiated, not create it with them. LMK if this makes it worse.

@brandonkelly
Copy link
Member

CKEditor 3.8.0 is tagged with that PR 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants