TS-31191 Add functionality to upload traces to multiple projects and via embedded resources #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embedded resources
snowbagoly
reviewed
Dec 1, 2023
snowbagoly
reviewed
Dec 7, 2023
snowbagoly
reviewed
Dec 11, 2023
|
|
||
| # Update the .resx file | ||
| Update-ResxFile -resxPath $path -key $key -value $value -project $project | ||
| if ($project -eq $null){ |
There was a problem hiding this comment.
Ah, sorry, I didn't notice this in the first round, but it looks like PowerShell actually gives a default value if you don't provide one for the parameter 😂 Can you modify the project null checks either to compare with empty string, or as with the other parameters, do if (-not $project) and if ($project)? 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embedded resources
Addresses issue TS-31191
CHANGELOG.mdupdatedPlease respect the Teamscale vote. Clean up findings before sending your change into review. Blacklist and report false-positives. Adjust the analysis profile if needed.