Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseGitProperties timestamp parse error for ISO 8601 time formats #464

Closed
ua4t4s0ft opened this issue May 23, 2024 · 3 comments
Closed

Comments

@ua4t4s0ft
Copy link

Hello CQSE Team,

We use the git-commit-id-maven-plugin to generate the git.properties file. After a breaking change #699 of the time format in Version 8.0.0 the agent throws a DateTimeParseException for e.g. '2024-02-12T13:26:52+02:00' (see screenshot)

image

image

It would be very helpful if the agent also supported the new time format.

Best Uwe

@DreierF
Copy link
Contributor

DreierF commented May 23, 2024

Thanks for taking the time to report the issue!
The agent already has an option artifactory-git-properties-commit-date-format that you can use to adjust the expected data format to e.g. yyyy-MM-dd'T'HH:mm:ssXXX. As this is the new default for the maven plugin we will be adjusting the agent to accept the new data format by default without additional configuration soon.

@RainerGanss
Copy link

Looking forward to that default ;-)

@AnonymFx
Copy link
Contributor

Sometimes, there are nice coincidences 🙂 I was just touching the code for a different feature and already improved the date parsing logic in non-Artifactory scenarios. So the fix was quite easy to carry over to the Artifactory use case 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants