Jackson Serialization Issue with Library Refresh Operation #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced Jackson ELM serialization with JAXB - Added shouldApplySoftwareSystemStamp to Library refresh parameters - Added tests - Removed tooling-cli directory from tooling module (seemed like that was committed by mistake(?))
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
=========================================
Coverage 20.25% 20.25%
- Complexity 1519 1521 +2
=========================================
Files 296 296
Lines 25191 25199 +8
Branches 3978 3979 +1
=========================================
+ Hits 5102 5104 +2
- Misses 19240 19248 +8
+ Partials 849 847 -2 ☔ View full report in Codecov by Sentry. |
brynrhodes
approved these changes
May 1, 2024
JPercival
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementers reported invalid ELM XML generation using the Library refresh operation with latest tooling (v3.4.0).
For description of issue and steps to reproduce see https://github.com/reason-healthcare/CQFToolingBug/blob/main/README.md
Additionally, an issue was reported with the shouldApplySoftwareSystemStamp parameter being ignored by the Library refresh operation.
Replaced Jackson ELM serialization with JAXB
Added shouldApplySoftwareSystemStamp to Library refresh parameters
Added tests (also tested in the repro repository referenced above)
Removed tooling-cli directory from tooling module (seemed like that was committed by mistake(?))
Github Issue:
I've read the contribution guidelines
Code compiles without errors
Tests are created / updated
Documentation is created / updated
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0