Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQF-Tooling Update and Test coverage increase #516

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Conversation

ddieppois
Copy link
Contributor

Description

  • Github Issue:
  • [ x] I've read the contribution guidelines
  • [ x] Code compiles without errors
  • [ x] Tests are created / updated
  • [ x] Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

daviddieppois added 2 commits February 27, 2024 01:16
Fixed QdmToQICore tool by updating getPageContent and added test to verify HTML pages creation.
Fixed QdmToQICore tool by updating getPageContent and added test to verify HTML pages creation.
@ddieppois ddieppois self-assigned this Feb 27, 2024
@ddieppois
Copy link
Contributor Author

Just updated the test to use @test and match the rest!

Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddieppois ddieppois requested a review from c-schuler February 28, 2024 18:37
Added example commands for multiple tools in Main (Updated Tech doc)
Created Test class for BundleToResource tool (Bundle decomposition). Input Data also added (bundle of libraryevaluationtest-bundle.json)
@ddieppois
Copy link
Contributor Author

Added a new test for Bundle decomposition (BundleToResource). Resource files are properly created. Input Data (Bundle library Test Json resources) also added for test purpose.

Added static final variable for BundleToResource args parameters
@ddieppois ddieppois changed the title QdmToQi core fix and test CQF-Tooling Update and Test coverage increase Feb 28, 2024
Added test for BundleToTransaction tooling.
Updated tech docs with example command
@ddieppois
Copy link
Contributor Author

Added BundleToTransaction test case with proper command in Main.java (Success)

@JPercival JPercival merged commit 241bd02 into master Feb 28, 2024
3 checks passed
@JPercival JPercival deleted the QdmToQICore-Fix branch February 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants