Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CQL export option to the StripGeneratedContent operation #511

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Add a CQL export option to the StripGeneratedContent operation #511

merged 9 commits into from
Jan 25, 2024

Conversation

JPercival
Copy link
Collaborator

@JPercival JPercival commented Jan 25, 2024 •
edited
Loading

Description

This PR adds functionality to also export CQL from Libraries when stripping generated content. There's also a fair amount of refactoring and cleanup. If you run the following commands, you can go from a Bundle of content to a set of of minimal resources and exported CQL (IOW, reverse engineer an IG from a Bundle)

tooling-cli -BundleToResources -p=path/to/input/bundle.json -e=json -op=content
tooling-cli -StripGeneratedContent  -ptr=./content -op=./stripped -cql=cql
  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@JPercival JPercival changed the title Adds a CQL export variable to StripGeneratedContent operation Add a CQL export option to the StripGeneratedContent operation Jan 25, 2024
@JPercival JPercival requested a review from ddieppois January 25, 2024 18:52
ddieppois
ddieppois approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@ddieppois ddieppois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is passing correctly and I don't see anything wrong with the code. Interesting to take a look at this feature, approved !

c-schuler
c-schuler approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@c-schuler c-schuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! I made some comments that could clean things up a bit more and reuse code in certain places. I will not block this PR for those small issues, however.

tooling/src/main/java/org/opencds/cqf/tooling/operations/stripcontent/ContentStripperR4.java Outdated Show resolved Hide resolved
tooling/src/main/java/org/opencds/cqf/tooling/operations/stripcontent/BaseContentStripper.java Show resolved Hide resolved
tooling/src/main/java/org/opencds/cqf/tooling/operations/stripcontent/BaseContentStripper.java Show resolved Hide resolved
@JPercival JPercival merged commit 2d81bc9 into master Jan 25, 2024
3 checks passed
@JPercival JPercival deleted the feature-add-cql-export branch January 25, 2024 22:42
@JPercival JPercival mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddieppois ddieppois ddieppois approved these changes

@c-schuler c-schuler c-schuler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPercival @c-schuler @ddieppois