Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-ExtractMatBundle modified to handle whole directory of files, test coverage added #475

Merged
merged 18 commits into from
Oct 13, 2023

Conversation

echicoine-icf
Copy link
Contributor

No description provided.

Evan Chicoine and others added 17 commits September 12, 2023 11:46
…loop into the execute method should -dir be passed in.
80% code coverage on ExtractMatBundleOperation class
…ly. Once extracted from a transaction bundle, the resource ID is logged, and if found in another bundle, removed from that bundle prior to processing it.
@mholck mholck self-requested a review October 11, 2023 20:06
Copy link
Contributor

@mholck mholck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok. Does work for extracting all MAT bundles under a directory and does not affect the original functionality of specifying a single JSON to extract.

@mholck mholck merged commit 929c130 into cqframework:master Oct 13, 2023
1 check failed
@c-schuler
Copy link
Contributor

@mholck & @echicoine-icf We appreciate the contributions, but please ensure the CI checks pass before merging PRs to ensure that master is always in a working state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants