Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "synonymDesignation" argument to GenericValueSetGenerator. Rest… #365

Merged

Conversation

sliver007
Copy link
Collaborator

@sliver007 sliver007 commented May 3, 2022

…ored BundleToResources Operation

Added the synonymDesignation argument to the GenericValueSetGenerator.

The synonymDesignation argument allows for the specification of where in the source spreadsheet a synonym value to be used for a display for codes can be found. If specified and a value is found, this will be added in the compose.include.concept.designation with a use of "synonym" (SNOMED code) and a value that is the value from the spreadsheet cell.

Also fixed a bug in the interation - the codeIteration was skipping every other row as a result of calling getNextValue to check for a value - that increments the iterator.

  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@sliver007 sliver007 requested a review from brynrhodes May 3, 2022 03:10
Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantaustin13 bryantaustin13 merged commit c395cc3 into master May 11, 2022
@bryantaustin13 bryantaustin13 deleted the feature_synonymDesignation_arg_generic_vs_generator branch May 11, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants