Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature cms104 investigation #308

Merged
merged 10 commits into from
Apr 14, 2022
Merged

Conversation

TychonautVII
Copy link
Contributor

@TychonautVII TychonautVII commented Nov 5, 2021

Updating the data requirements test for CMS 104 to show that an expected data requirement is missing. This PR is tied to the bug reporrt here: #309

Description

  • Slightly refactored tests to move common functionality into a method so I could save the refreshed measures out more easily

  • added additional logic to the CMS104 test to cause it to fail and made the bug I'm reporting in the issue more obvious

  • I've read the contribution guidelines

  • Code compiles without errors

  • Tests are created / updated

  • [N/A] Documentation is created / updated

public void TestCMS125FHIR() {
// Extract the bundle
// NOTE: This is a 2021-AUFHIR measure, this is the test to use as the template to add the rest of the content for testing
private List<DataRequirement> StartMatOutputTest(String matBundleName, String measureLibraryName){
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to more some common functionality into a method to make it so I could save the refreshed measure to a directory

List<String> edrs = List.of("ServiceRequest","Procedure","Encounter");
checkExpectedResourcesPresent(drs, edrs);

}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple test I added to CMS 104 to check to make sure that the expected FHIR resources are present. I am not sure that this list is complete, but this is enough for the test to fail, because the expected resource "Encouter" is not present

Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed several issues with data requirements in the elm-fhir package, now part of 1.5.5-SNAPSHOT. Updated the test with the latest package from measure developers and verified it is functional. Would be good to get more detailed on the verification based on the manual review from measure developers, but it is minimally functional with just checking for data requirements with the given resource types.

Copy link
Contributor

@pmechineniesac pmechineniesac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMS147 can’t find service request
CMS125 shows the found expected data requirements
After the CQL translator change, all of the measures except for CMS147 are failing in the refreshmeasure stage. The measure is unable to be returned from line 61 of the refreshMeasure function. In fact, even CMS71 is now failing which was not failing prior to the translator change.

@pmechineniesac pmechineniesac requested review from brynrhodes and removed request for brynrhodes and abdullah-git1 February 1, 2022 17:18
@brynrhodes brynrhodes merged commit b0bc714 into master Apr 14, 2022
@brynrhodes brynrhodes deleted the feature-cms104_investigation branch April 14, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants