Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooling maintenance #261

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Tooling maintenance #261

merged 2 commits into from
Jul 13, 2021

Conversation

JPercival
Copy link
Collaborator

Description
This PR is a hodge-podge of maintenance items for the tooling:

  • Standardizes on TestNG
  • Standardizes on slf4j / logback
  • Upgrades various dependencies
  • Adds exclusions to the maintenance script
  • Fixes build issues on Maven 3.8.1 by adding appropriate exclusions to the pom for missing dependencies
  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@JPercival JPercival added bug Something isn't working dependencies Pull requests that update a dependency file labels Jul 12, 2021
@JPercival JPercival self-assigned this Jul 12, 2021
bryantaustin13
bryantaustin13 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
mvn clean install -U with version 3.8.1 works just fine

@bryantaustin13 bryantaustin13 merged commit 17cfd50 into master Jul 13, 2021
@bryantaustin13 bryantaustin13 deleted the fix-script branch July 13, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreyno77 jreyno77 jreyno77 approved these changes

@bryantaustin13 bryantaustin13 bryantaustin13 approved these changes

Assignees

@JPercival JPercival

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPercival @bryantaustin13 @jreyno77