Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh exception fix #228

Merged
merged 4 commits into from
May 14, 2021
Merged

Refresh exception fix #228

merged 4 commits into from
May 14, 2021

Conversation

bryantaustin13
Copy link
Contributor

@bryantaustin13 bryantaustin13 commented May 13, 2021

logic definitions were causing an exception. Added null checks
Description

Logic definition extensions were causing an exception. Added null checks to avoid that.

  • Github Issue:
  • [ X] I've read the contribution guidelines
  • [ X] Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@bryantaustin13 bryantaustin13 requested a review from sliver007 May 13, 2021 20:59
Copy link
Collaborator

@rob-reynolds rob-reynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rob-reynolds rob-reynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need to be resolved.

@brynrhodes brynrhodes merged commit 88f4653 into master May 14, 2021
@brynrhodes brynrhodes deleted the refreshExceptionFix branch May 14, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants