Update CPS spec support to 0.12 #104
Conversation
dcbaker
force-pushed
the
submit/update-to-0.12
branch
from
a8e2f00 to
6312382
Compare
|
|
dcbaker
force-pushed
the
submit/update-to-0.12
branch
2 times, most recently
from
3e58837 to
d9ae69c
Compare
dcbaker
force-pushed
the
submit/update-to-0.12
branch
2 times, most recently
from
209d12d to
0af539a
Compare
src/cps/env.cpp
Outdated
| // Copyright © 2023-2024 Dylan Baker | ||
| // Copyright © 2024 Tyler Weaver | ||
| // Copyright © 2024 Dylan Baker |
There was a problem hiding this comment.
Do you have an editor tool doing this, your name is in the first line.
There was a problem hiding this comment.
Yes, my editor is doing that and I missed undoing one of them apparently... Sigh
There was a problem hiding this comment.
np, figured it was some tool doing this
Not really, I just look through the git history commit by commit between the two versions and made a list in the linked issue. I asked on slack (and I think we agreed?) to start adding a git tag each time the spec version is bumped to to help with this. |
|
You don't happen to have the commit hash you started with for 0.10 handy do you? |
dcbaker
force-pushed
the
submit/update-to-0.12
branch
from
0af539a to
f71b9fc
Compare
|
Pretty sure it was 97ac8d77f878768cb6ee15d3f9b848e8f1149b55 |
|
This seems like an important change to land. Is there anything specific I should help with next? I looked through the pc file parser mr, I think I'm a bit confused about the need for this tool to parse pc files. I have been out of the loop for the last few months though so I probably just missed something. |
I'm not sure what happened here, whether this changed at some point or it was just always implemented wrong.
This provides better self documentation
This updates CPS files and tests, since we now support the 0.12 spec and not the 0.10/0.11 spec
Since 0.12 dropped support for undefines, we can remove the code to support it as well.
This handles the case of "*", including the proper override for when a language is specifically defined with its own values. Fixes: cps-org#69
dcbaker
force-pushed
the
submit/update-to-0.12
branch
from
f71b9fc to
5caeb0f
Compare
The only thing I'm working on at the moment is trying to get the The goal of the .pc file parsing is so that cps-config can be used as s drop in replacement for pkg-config, particularly in autotools and older versions of build systems (someone who has a hard requirement to use a very old version of CMake or Meson, for example), to that end being able to fall back to finding a .pc file instead of a .cps file for projects that only provide .pc files is pretty important. |
This updates the support of cps-config to CPS 0.12. The only change that currently affects cps-config is the changes to the "definitions" field. This includes a fix for a bug where cps-config would look for "defines" instead of "definitions"
Currently based on #95
Fixes: #103