Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OVERRIDE_FIND_PACKAGE doesn't work #498

Closed
patstew opened this issue Aug 23, 2023 · 4 comments · Fixed by #604
Closed

OVERRIDE_FIND_PACKAGE doesn't work #498

patstew opened this issue Aug 23, 2023 · 4 comments · Fixed by #604

Comments

@patstew
Copy link
Contributor

patstew commented Aug 23, 2023

I think because CPM avoids calling FetchContent_MakeAvailable(?), the OVERRIDE_FIND_PACKAGE argument to FetchContent_Declare doesn't work. The redirect files don't get created.
@anthonyalayo
Copy link

I found this issue after looking into the same thing. @TheLartians , could this get attention?

@TheLartians
Copy link
Member

Unfortunately I currently don't have the time to look into this, but would be very happy to review a PR that suggests a fix.

@ethindp
Copy link

ethindp commented Jul 21, 2024

I'm running into this bug too: a dependency requires pugixml, and even though I included it via CPMAddPackage it still claims it can't find it.

@ethindp
Copy link

ethindp commented Jul 21, 2024

Odd thing is that it worked fine a couple days ago, I have no idea what changed.

patstew added a commit to patstew/CPM.cmake that referenced this issue Sep 24, 2024
@patstew
Add find_package overrides that also work in CONFIG mode (cpm-cmake#498)
b34fff7
@patstew patstew mentioned this issue Sep 24, 2024
Merged
patstew added a commit to patstew/CPM.cmake that referenced this issue Sep 24, 2024
@patstew
Add find_package overrides that also work in CONFIG mode (cpm-cmake#498)
121410c
@patstew patstew mentioned this issue Dec 12, 2024
Closed
patstew added a commit to patstew/CPM.cmake that referenced this issue Dec 18, 2024
@patstew
Add find_package overrides that also work in CONFIG mode (cpm-cmake#498)
b9499c0
patstew added a commit to patstew/CPM.cmake that referenced this issue Dec 20, 2024
@patstew
Add find_package overrides that also work in CONFIG mode (cpm-cmake#498)
8497a75
patstew added a commit to patstew/CPM.cmake that referenced this issue Dec 20, 2024
@patstew
Add find_package overrides that also work in CONFIG mode (cpm-cmake#498)
8ff2d08
TheLartians pushed a commit that referenced this issue Dec 20, 2024
@patstew
Add find_package overrides that also work in CONFIG mode (#498) (#604)
9ddfe1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add find_package overrides that also work in CONFIG mode (#498) patstew/CPM.cmake
4 participants
@TheLartians @patstew @ethindp @anthonyalayo