Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SwiftCompileCaptureGroup Bug #306

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Aug 8, 2024

Fix a bug in the SwiftCompileCaptureGroup where it missed files with escaped spaces. Add a unit test that considers the previously missed output, and simplify the regex to more exhaustively consider filenames. As part of this change, update the regex's capturing groups, and use lastPathComponent to extract filename from the already captured filePath.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (b674bbe) to head (f70c7f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   86.87%   86.88%           
=======================================
  Files          14       14           
  Lines        1631     1632    +1     
=======================================
+ Hits         1417     1418    +1     
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta force-pushed the charles/SwiftCompileBug branch from aa46ef9 to f70c7f9 Compare August 8, 2024 00:15
@cpisciotta cpisciotta changed the title Fix SwiftCompile Bug Fix SwiftCompileCaptureGroup Bug Aug 8, 2024
@cpisciotta cpisciotta marked this pull request as ready for review August 8, 2024 00:26
@cpisciotta cpisciotta merged commit a27d1eb into main Aug 8, 2024
13 checks passed
@cpisciotta cpisciotta deleted the charles/SwiftCompileBug branch August 8, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant