Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftDriverJobDiscoveryCompilingCaptureGroup #305

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

cpisciotta
Copy link
Owner

@cpisciotta cpisciotta commented Aug 7, 2024

Changes

Add a concrete CaptureGroup for SwiftDriverJobDiscovery output. At this time, don't format it, since it's likely uninformative to a developer.

Testing

  • Added new unit tests
  • Performance regression tests showed notably positive improvements
  • No unexpectedly missed output in the formatted log

@cpisciotta cpisciotta force-pushed the charles/SwiftDriverJobDiscovery branch from 608b2f1 to 82babc2 Compare August 7, 2024 23:40
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.87%. Comparing base (ab7ca70) to head (2440f79).

Files Patch % Lines
...rces/XcbeautifyLib/Renderers/OutputRendering.swift 0.00% 2 Missing ⚠️
Sources/XcbeautifyLib/Formatter.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   86.95%   86.87%   -0.08%     
==========================================
  Files          14       14              
  Lines        1618     1631      +13     
==========================================
+ Hits         1407     1417      +10     
- Misses        211      214       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpisciotta cpisciotta force-pushed the charles/SwiftDriverJobDiscovery branch from 82babc2 to 98142e0 Compare August 7, 2024 23:45
@cpisciotta cpisciotta force-pushed the charles/SwiftDriverJobDiscovery branch from 98142e0 to 2440f79 Compare August 7, 2024 23:46
@cpisciotta cpisciotta marked this pull request as ready for review August 7, 2024 23:46
@cpisciotta cpisciotta linked an issue Aug 7, 2024 that may be closed by this pull request
@cpisciotta cpisciotta merged commit b674bbe into main Aug 8, 2024
11 of 13 checks passed
@cpisciotta cpisciotta deleted the charles/SwiftDriverJobDiscovery branch August 8, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Output] Support SwiftDriverJobDiscovery Output
1 participant