Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Xcode 16 Beta 4 #297

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

giginet
Copy link
Contributor

@giginet giginet commented Jul 31, 2024

I tried to build this on Xcode 16 Beta 4. However, the following error occurred.

Screenshot 2024-07-31 at 21 46 29

This project enables the upcoming feature InternalImport, which may cause this problem.

This PR fixes the build with the latest Xcode 16 and avoids warnings.

@giginet giginet requested a review from cpisciotta as a code owner July 31, 2024 12:50
@giginet giginet changed the title Support Xcode 16 Support Xcode 16 Beta 4 Jul 31, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (80d0acb) to head (25619ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          14       14           
  Lines        1600     1600           
=======================================
  Hits         1389     1389           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@cpisciotta cpisciotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giginet Thanks for your contribution and for resolving this issue! LGTM 👍 I'll add Xcode 16 and Swift 6 to CI to avoid this in future releases.

@cpisciotta cpisciotta merged commit 0cd7f0c into cpisciotta:main Aug 6, 2024
11 checks passed
@giginet giginet deleted the support-xcode16 branch August 6, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants