-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept pathlib.Path as arguments #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for a few minor critiques this looks excellent. Thank you.
@cpburnz Thanks for having a look. |
Looks good, thanks. |
You are welcome. |
118: Update pathspec to 0.8.0 r=rehandalal a=pyup-bot This PR updates [pathspec](https://pypi.org/project/pathspec) from **0.7.0** to **0.8.0**. <details> <summary>Changelog</summary> ### 0.8.0 ``` ------------------ - `Issue 30`_: Expose what patterns matched paths. Added `util.detailed_match_files()`. - `Issue 31`_: `match_tree()` doesn't return symlinks. - `Issue 34`_: Support `pathlib.Path`\ s. - Add `PathSpec.match_tree_entries` and `util.iter_tree_entries()` to support directories and symlinks. - API change: `match_tree()` has been renamed to `match_tree_files()`. The old name `match_tree()` is still available as an alias. - API change: `match_tree_files()` now returns symlinks. This is a bug fix but it will change the returned results. .. _`Issue 30`: cpburnz/python-pathspec#30 .. _`Issue 31`: cpburnz/python-pathspec#31 .. _`Issue 34`: cpburnz/python-pathspec#34 ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pathspec - Changelog: https://pyup.io/changelogs/pathspec/ - Repo: https://github.com/cpburnz/python-path-specification </details> Co-authored-by: pyup-bot <[email protected]>
This PR modernizes
pathspec
to work with pathlib.Path objects.normalize_file
andnormalize_files
Closes: #33