From 61d5250c555f254203b74fe9510bef96db82d7f4 Mon Sep 17 00:00:00 2001 From: jonjohnsonjr Date: Thu, 16 Sep 2021 10:48:12 -0700 Subject: [PATCH] Drop scary warning (#439) --- pkg/build/gobuild.go | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/pkg/build/gobuild.go b/pkg/build/gobuild.go index 81d5d74bba..9ff2f8a5e3 100644 --- a/pkg/build/gobuild.go +++ b/pkg/build/gobuild.go @@ -48,22 +48,6 @@ import ( const ( defaultAppFilename = "ko-app" - - gorootWarningTemplate = `NOTICE! ------------------------------------------------------------------ -ko and go have mismatched GOROOT: - go/build.Default.GOROOT = %q - $(go env GOROOT) = %q - -Inferring GOROOT=%q - -Run this to remove this warning: - export GOROOT=$(go env GOROOT) - -For more information see: - https://github.com/google/ko/issues/106 ------------------------------------------------------------------ -` ) // GetBase takes an importpath and returns a base image reference and base image (or index). @@ -233,11 +217,10 @@ func NewGo(ctx context.Context, dir string, options ...Option) (Interface, error } // If $(go env GOROOT) successfully returns a non-empty string that differs from - // the default build context GOROOT, print a warning and use $(go env GOROOT). + // the default build context GOROOT, use $(go env GOROOT) instead. bc := gb.Default bc.Dir = dir if goroot != "" && bc.GOROOT != goroot { - log.Printf(gorootWarningTemplate, bc.GOROOT, goroot, goroot) bc.GOROOT = goroot }