Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version of Clang-format #851

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Specify version of Clang-format #851

merged 2 commits into from
Sep 24, 2024

Conversation

hfp
Copy link
Member

@hfp hfp commented Sep 24, 2024

  • clang-format is not stable version-to-version
  • Hook is reformatting code already committed,
    it may be better to only change touched code

@hfp hfp force-pushed the format branch 5 times, most recently from 64ee200 to 1e01df1 Compare September 24, 2024 07:31
- clang-format is not stable version-to-version
- Hook is reformatting code already committed,
  it may be better to only change touched code
@hfp
Copy link
Member Author

hfp commented Sep 24, 2024

If this becomes "green", I will merge the PR. However, .clang-format shall be adjusted in a follow-up change. Apparently, not even this config is digested in a stable fashion including errors for certain configuration keys.

@hfp
Copy link
Member Author

hfp commented Sep 24, 2024

Syntax of additional_dependencies seems to be not as documented but rather follows Pip's version spec (clang-format~=19.1.0).

@hfp hfp merged commit 85cedf1 into cp2k:develop Sep 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant