Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Debug from derive_more #3145

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Use Debug from derive_more #3145

merged 3 commits into from
Dec 2, 2024

Conversation

m-lord-renkse
Copy link
Contributor

@m-lord-renkse m-lord-renkse commented Dec 2, 2024 •
edited
Loading

Description

Use Debug from derive_more crate.
The Derivative crate wasn't fully removed because of the Default derives.

Changes

  • Use Debug from derive_more crate
  • Update derive_more to use the first stable release 1.0.0
  • Remove unused crates dependencies

How to test

  1. Unit test
  2. Regression tests

@m-lord-renkse m-lord-renkse marked this pull request as ready for review December 2, 2024 09:57
@m-lord-renkse m-lord-renkse requested a review from a team as a code owner December 2, 2024 09:57
MartinquaXD
MartinquaXD approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!
Surprising how many dependencies were unused. How did you find them? IIRC we used cargo-udeps in the past but that apparently missed a ton of stuff.

@m-lord-renkse
Copy link
Contributor Author

Neat! Surprising how many dependencies were unused. How did you find them? IIRC we used cargo-udeps in the past but that apparently missed a ton of stuff.

Yeah, because we used in the past cargo-udeps at the project level, which only detects unused dependencies from the general Cargo.toml point of view. I needed to go crate by crate and run cargo-udeps. Maybe we could have this in the CI 🤔

squadgazzz
squadgazzz approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-lord-renkse m-lord-renkse enabled auto-merge (squash) December 2, 2024 11:49
@m-lord-renkse m-lord-renkse merged commit 69a68bf into main Dec 2, 2024
11 checks passed
@m-lord-renkse m-lord-renkse deleted the use-debug-from-derive-more branch December 2, 2024 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@squadgazzz squadgazzz squadgazzz approved these changes

@MartinquaXD MartinquaXD MartinquaXD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-lord-renkse @MartinquaXD @squadgazzz