Driver & Autopilot: Remove deny_unknown_fields #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squadgazzz
reviewed
Nov 27, 2024
MartinquaXD
reviewed
Nov 28, 2024
squadgazzz
approved these changes
Nov 28, 2024
Good point! on it! 👌 |
m-lord-renkse
changed the title
MartinquaXD
approved these changes
Nov 28, 2024
There are other ways to avoid crashing when new field is added, for example adding deserialization logic that temporarily accepts multiple versions of the data received.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
deny_unknown_fieldsfrom theDeserializedobjects in order to avoid crashing when new fields are added.