Remove crates vscode extension dependency from devcontainer
#3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Devcontainer json definition file contains vscode extension dependency:
crateswhich is deprecated. As this extension is only an utility for checkingCargo.tomldependency creates versions and is not needed for devcontainer to work on our codebase, we decided to drop that extension from our devcontainer json definition file.Anyone can still use
cratesor similar extension (likedependi) in devcontainer by installing it locally in vscode.Reference discussion: link
Changes
Updated
devcontainer.jsonfile.How to test
Open vscode from
servicesfolder and on popup window click option "Open in devcontainer" (docker daemon is required to operate). Wait for containers setup and validation by rust analyzer.