Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move app-data-hash into app-data crate #3105

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Move app-data-hash into app-data crate #3105

merged 3 commits into from
Nov 5, 2024

Conversation

MartinquaXD
Copy link
Contributor

Changes

Merges app-data-hash crate into app-data crate and deletes shared::app_data to reduce the scope of the shared crate.

@MartinquaXD MartinquaXD requested a review from a team as a code owner November 5, 2024 07:35
m-lord-renkse
m-lord-renkse approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@m-lord-renkse m-lord-renkse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪚

Base automatically changed from move-api-code-into-orderbook to main November 5, 2024 10:40
@MartinquaXD MartinquaXD enabled auto-merge (squash) November 5, 2024 10:45
@MartinquaXD MartinquaXD merged commit 039be41 into main Nov 5, 2024
11 checks passed
@MartinquaXD MartinquaXD deleted the merge-app-data-crates branch November 5, 2024 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-lord-renkse m-lord-renkse m-lord-renkse approved these changes

@squadgazzz squadgazzz squadgazzz approved these changes

@sunce86 sunce86 sunce86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinquaXD @sunce86 @squadgazzz @m-lord-renkse