Replace system allocator with mimalloc #3087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I looked more into the supposed memory leak and noticed that the system allocator requires unreasonable amounts of memory compared to mimalloc so I replaced it for all the binaries.
Here we can see the memory footprint of the api pod with
mimalloc
(green) and the system allocator (yellow). The served traffic is the same but the system allocator continues to require more and more memory - probably because it's worse at dealing with memory fragmentation thanmimalloc
.