Move current block stream into ethrpc
#1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
reviewed
Aug 29, 2023
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl BlockRetrieving for Web3 { |
There was a problem hiding this comment.
We can get rid of the BlockRetrieving trait and move this into the retriever module right?
Note: I would do that refactor in a follow up to keep this PR purely about moving code around.
There was a problem hiding this comment.
Yep. Also had a few other refactoring ideas but wanted to do them in a separate PR as well. 👌
nlordell
reviewed
Aug 29, 2023
| /// Command line arguments for creating global block stream. | ||
| #[derive(Debug, Parser)] | ||
| #[group(skip)] | ||
| pub struct Arguments { |
There was a problem hiding this comment.
Maybe move this to shared::arguments::Arguments?
There was a problem hiding this comment.
Initially I wanted to do that together with moving ethrpc arguments because I forgot that last time (see PR description). But I can do that now as well.
There was a problem hiding this comment.
Follow up is fine. Should should have RTFPRD.
nlordell
approved these changes
Aug 29, 2023
fleupold
approved these changes
Aug 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall idea is to move block streams and event streams into the
ethrpccrate. This PR takes care of thecurrent_blockstream.Note that the files
shared::ethrpcandshared::current_blockstill exist but they only contain the CLI logic.In a follow up refactoring it would make sense to move that last remaining logic into
shared::arguments.Test Plan
Only moved code around so the e2e tests should be enough.