Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Hook up configuration options for BadTokenMonitor #3094

Open
MartinquaXD opened this issue Oct 30, 2024 · 0 comments
Open

chore: Hook up configuration options for BadTokenMonitor #3094

MartinquaXD opened this issue Oct 30, 2024 · 0 comments

Comments

@MartinquaXD
Copy link
Contributor

MartinquaXD commented Oct 30, 2024

Background

We should be able to configure the driver side bad token detection for each solver individually since they might support different tokens.

Things that need to be configurable on a per-solver basis:

  • mapping token => supported_or_not
  • how long a token should be marked as unsupported (to err on the safe side tokens should probably not be banned forever immediately)
  • parameters needed to configure the heuristic
    • depends on the actual heuristic and implementation - could be sth like:
      • minimum of observed failures before deny-listing may happen
      • ratio of working vs. revering solutions before deny-listing
  • which mode to run (enabled vs. logOnly)

To make things easier all these should have reasonable defaults so the feature can start running without having to merge a huge infra PR before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant