Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set up logging, metrics, alerts for BadTokenMonitor #3093

Open
MartinquaXD opened this issue Oct 30, 2024 · 0 comments
Open

chore: Set up logging, metrics, alerts for BadTokenMonitor #3093

MartinquaXD opened this issue Oct 30, 2024 · 0 comments

Comments

@MartinquaXD
Copy link
Contributor

Background

In order to monitor and reason about the driver side bad token detection we need helpful logs and enough metrics to set up reasonable alerts for it.

Logs I would expect:

  • log address of the token when it gets added to the unsupported list
  • log when token leaves the unsupported list (e.g. TTL exceeded)
  • log which order UIDs get filtered out due to unsupported tokens
  • to make manual debugging easier it might be nice to log the involved tokens in each (non-merged) solution that failed to simulate

Metrics I would expect:

  • number of currently unsupported tokens
  • number of orders filtered due to unsupported tokens

Alerts I would expect:

  • alert when the number of filtered orders is too high

Of course additional logs, alerts, metrics can be added if they are deemed helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant