Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add is_winner flag to solver competition endpoint #3070

Open
sunce86 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3127
Open

feat: Add is_winner flag to solver competition endpoint #3070

sunce86 opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3127
Assignees
@m-lord-renkse

Comments

@sunce86
Copy link
Contributor

sunce86 commented Oct 18, 2024

Problem

We need new is_winner boolean field for each solution returned with solver_competition endpoint, to indicate which solutions were chosen as winners. Currently, this is implicit and the last solution in the list (with ranking=1) is considered the winner.

Suggested solution

Add is_winner boolean to each solution json object.
@m-lord-renkse m-lord-renkse linked a pull request Nov 14, 2024 that will close this issue
Open
@m-lord-renkse m-lord-renkse self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-lord-renkse m-lord-renkse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add is_winner to solver competition endpoints cowprotocol/services
2 participants
@sunce86 @m-lord-renkse