feat: Refactor get_auction API to return historic entries
#2844
Comments
This was referenced Sep 17, 2024
sunce86
added a commit
that referenced
this issue
Sep 18, 2024
# Description Currently fee policies are saved only for winning solution. This PR saves fee policies for all auction orders. This is needed for at least two reasons: 1. As discussed [in the PR](#2980 (comment)), fee policies will be needed for all proposed solutions during a competition so that the score could be reconstructed in circuit breaker. 2. [For historical get_auction](#2844).
|
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
|
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Currently
get_auctionAPI function returns only the latest auction built by autopilot.We need to add possibility for this endpoint to return auction by given auction_id/block_number.
Suggested solution
Most of the data can be fetched from database even now. Tables of interest are
orders,auction_orders,auction_prices,fee_policies,surplus_capturing_jit_order_owners. Things missing in the database are:auction.block,auction. latest_settlement_blockandorder.executedfield. These fields should be saved and then all the data required to reconstruct the auction will exist.@fleupold commented (todo check):
Can’t auction.lastest_settlement_block and executed be reconstructed from the existing trades/settlements table assuming auction.block is saved?
Additional context
Solvers, solver-team and other parties are very interested in this endpoint and this could have a significant impact on those parties making their work easier, faster and cleaner.
The text was updated successfully, but these errors were encountered: