Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Still paying high gas for non-revertable txs #2196

Closed
sunce86 opened this issue Dec 20, 2023 · 2 comments
Closed

bug: Still paying high gas for non-revertable txs #2196

sunce86 opened this issue Dec 20, 2023 · 2 comments
Labels
bug Something isn't working question Further information is requested

Comments

@sunce86
Copy link
Contributor

sunce86 commented Dec 20, 2023

Problem

#2176 did not help. Apparently, we have somewhere a bug with internalize flag, because transaction that get internalized (0x577767a68da9ad92d29986679ae30cd27c7394d20d91bb42c22bf61a42f49110) still return revertable() == true.

There might be several problems here:

  1. How did we end up internalizing the settlement with interaction having internalize==false.
  2. Do we properly propagate internalize flag from solvers? AFAIS they are sending false for these simple interactions, why would they? It's in their interest to allow it for lower costs.

Impact

Spending more gas than necessary.

To reproduce

Analyze the driver logs for the example transaction
0x577767a68da9ad92d29986679ae30cd27c7394d20d91bb42c22bf61a42f49110

Expected behaviour

We should have not disabled the Mempool in this case.

@sunce86 sunce86 added the bug Something isn't working label Dec 20, 2023
@fleupold
Copy link
Contributor

The transaction you shared here is actually not an internalisation but one CoW Swap order + a single interaction which is a private market maker trade.

Technically, those pose no MEV risk neither and thus don't require private submission, but right now we have no way to identify if an interaction is "risky"

Please let me know if there are other examples of this, or if the issue can be closed.

@fleupold fleupold added the question Further information is requested label Dec 21, 2023
@sunce86
Copy link
Contributor Author

sunce86 commented Dec 22, 2023

Ah, sorry for false alarm then.
Verified that low gas prices are used for internalized settlements: https://etherscan.io/tx/0xa8dfd291f6fa29b5043c7b05426f98c6f16e8708a382c0f3c7e58fcc28c3a52b

Closing the issue.

@sunce86 sunce86 closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants