Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip fee policies for TWAP orders #2115

Closed
sunce86 opened this issue Dec 3, 2023 · 1 comment
Closed

feat: Skip fee policies for TWAP orders #2115

sunce86 opened this issue Dec 3, 2023 · 1 comment
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Dec 3, 2023

Problem

TWAP orders are limit orders. Since we initially don't want to charge fees for TWAP orders (and once we eventually do, the policy will probably be different from regular limit orders (regular limit order will be charged on quote deviation fee and TWAP orders on volume based fee), then we need to skip TWAP orders when we define fee policy on each auction.

Suggested solution

We need a way to differentiate between limit orders and TWAP orders. Once we have that, just set the empty fee policy for them.

@sunce86 sunce86 added the E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details label Dec 3, 2023
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 15, 2024

Update: TWAP orders are limit orders with high slippage (~ 10%). For initial protocol fee launch (where we charge for out-of-market limit orders), TWAP orders will be treated the same way as all other limit orders. No custom implementation is needed for them.

@sunce86 sunce86 closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Development

No branches or pull requests

1 participant