Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expand Order with executed protocol fees #2113

Closed
1 task
sunce86 opened this issue Dec 2, 2023 · 1 comment
Closed
1 task

feat: Expand Order with executed protocol fees #2113

sunce86 opened this issue Dec 2, 2023 · 1 comment
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Dec 2, 2023

Problem

Once the calculated protocol fees are in the order_execution table, we should adjust the sql queries for fetching the orders from database to include the executed protocol fees.

Acceptance criteria

  • get_order returns Order struct that contains executed protocol fees to be shown in UI
@sunce86 sunce86 added the E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details label Dec 2, 2023
@sunce86 sunce86 mentioned this issue Dec 2, 2023
Closed
9 tasks
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 3, 2024

Closed as not needed. Decided to just provide the input for calculating the protocol fees.

@sunce86 sunce86 closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:4.2 Protocol Fee Implementation See https://github.com/cowprotocol/pm/issues/29 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunce86