Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Unify full_order_into_model_order #2110

Closed
sunce86 opened this issue Dec 2, 2023 · 6 comments
Closed

chore: Unify full_order_into_model_order #2110

sunce86 opened this issue Dec 2, 2023 · 6 comments

Comments

@sunce86
Copy link
Contributor

sunce86 commented Dec 2, 2023

Background

Original comment: #2107 (comment)

We have two different (but very similar) functions for converting database order to in-memory order:
https://github.com/cowprotocol/services/blob/main/crates/orderbook/src/database/orders.rs#L413
https://github.com/cowprotocol/services/blob/main/crates/shared/src/db_order_conversions.rs#L40

We should use the one from the shared crate.
@sunce86 sunce86 mentioned this issue Dec 2, 2023
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Feb 6, 2024
@sunce86 sunce86 removed the stale label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Apr 7, 2024
@sunce86 sunce86 removed the stale label Apr 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 8, 2024
@sunce86
Copy link
Contributor Author

sunce86 commented Jul 11, 2024

Not done.

@sunce86 sunce86 reopened this Jul 11, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Sep 10, 2024
@sunce86 sunce86 removed the stale label Sep 10, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunce86