-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Implement DEX rate limiter retry mechanism #2096
Comments
This only affects the first order in the auction (as others will already wait for the back_off interval before attempting to execute), right? |
Theoretically this can happen to any order in the auction. The issue is that the backoff interval configured in the rate limiting strategy might not be in sync with whatever rate limiting strategy the external API actually enforces. One easier way out would be to configure our However, over all I think having the retry would be nice but I would not implement it under all circumstances. If the implementation ends up verbose and hard to understand I would probably prefer not to introduce the complexity since you already mentioned that orders get retried in the next auction. |
That's the current default value: services/crates/solvers/src/infra/config/dex/file.rs Lines 84 to 86 in 07a966e
Closing the issue since orders will be retried in the next auctions. Adding complexity here doesn't seem to be profitable. |
Background
The DEX rate limiter skips the rate-limited order, which could be avoided with a retry mechanism.
Details
The suggestion is to implement a configurable retry mechanism for the rate-limited orders instead of just skipping them. A config with only the
max_retries
param should be sufficient.Acceptance criteria
Depends on #2071
The text was updated successfully, but these errors were encountered: