[Bug] Coverlet is not counting the model properties

[ming-tsai]

Hi there,
I'm using coverlet.msbuild to generate the coverlet and publish to SonarScanner, recently I upgrade v2.7.0 to v2.9.0, but on v2.9.0 is not counting the model properties.

Evidence

v2.9.0

v2.7.0

[petli]

This has been fixed in master (#328 #912) and will be included in the next release.

[ming-tsai]

Hi @petli, thanks, so, when is the next release day?

[petli]

Do you have any date planned already, @MarcoRossignoli ?

[MarcoRossignoli]

No atm...we need to talk about versions alignment cc: @tonerdo #874 and maybe if we've room we could fix this #900
We should also merge this new feat #904

[MarcoRossignoli]

BTW not sure that the issue here is related to that new feature...the new feat will exclude autoprops.

@ming-tsai can you attach your command line?

[ming-tsai]

Hi @MarcoRossignoli,
This the command that I use to generate the coverage.

dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover --logger trx

The issue has nothing to do with auto-props

[MarcoRossignoli]

Can you try with 2.8.1?

[ming-tsai]

Same than 2.9.0 and I get these warnings

warning : [coverlet] Unable to instrument module: source\repos\Project\Project.Test\bin\Debug\netcoreapp3.0\System.ComponentModel.Annotations.dll because : No symbol found for file: source\repos\Project\Project.Test\bin\Debug\netcoreapp3.0\System.ComponentModel.Annotations.dll [source\repos\Project\Project.Test\Project.Test.csproj]
warning : [coverlet] Unable to instrument module: source\repos\Project\Project.Test\bin\Debug\netcoreapp3.0\System.Text.Encodings.Web.dll because : No symbol found for file: source\repos\Project\Project.Test\bin\Debug\netcoreapp3.0\System.Text.Encodings.Web.dll [source\repos\Project\Project.Test\Project.Test.csproj]

[MarcoRossignoli]

Warnings are ok, but for your problem we need a repro because is not expected, we got similar issue on 2.9.0 because we fixed a bug on ExcludeByAttribute feature #794 (comment) but your command line seems ok.

[ming-tsai]

Hi @MarcoRossignoli,
I will try to create an example repo and attached to here.

[ming-tsai]

Hi @MarcoRossignoli,
Let me attach the example repo.
v2.7.0

v2.9.0

Project
Example.zip

[ming-tsai]

Hi @MarcoRossignoli,
Any updates?

[MarcoRossignoli]

Sorry @ming-tsai I'm bit busy these days...I'll think to work on it in the weekend 🙇

[ming-tsai]

Hiya 👋,
Any update?

[MarcoRossignoli]

@ming-tsai Sorry for the delay, busy times I'll take a look asap

[ming-tsai]

Ok @MarcoRossignoli, let me know when has any update

[MarcoRossignoli]

Thanks for the patience and sorry!

[ming-tsai]

Thanks for the patience and sorry!

Don't worry 🧐, I will use v2.7.0 until fix this issue

[MarcoRossignoli]

@ming-tsai I cannot repro with your sample

Can you verify that my setup/command line is like your?

[ming-tsai]

Hi @MarcoRossignoli, I'm going to test in my computer

[ming-tsai]

Hi @MarcoRossignoli, sorry for the late response, my output is the same as yours but I'm sure that it is not counting the model properties.
The v2.7.0 coverage is 100% but on the v2.9.0 is 84%.
Why the previous version is counting and the new version is not? and what should I do with this type of unit test?

[MarcoRossignoli]

I'll take another deep look to understand the counting difference, I'm pretty sure that the culprit is some accounting fix

[ming-tsai]

Hi @MarcoRossignoli, please update the labels

[MarcoRossignoli]

@ming-tsai I did some test with nightly and 100% comes back, so as @petli said should be fixed on master.

 C:\git\playground\coverlet\Example                                                                                                                                                                                                                                [15:21]
❯ dotnet test /p:CollectCoverage=true
  Determining projects to restore...
C:\Program Files\dotnet\sdk\5.0.200-preview.20601.7\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets(28,5): warning NETSDK1138: The target framework 'netcoreapp3.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [C:\git\playground\coverlet\Example\Example.Test\Example.Test.csproj]
  All projects are up-to-date for restore.
C:\Program Files\dotnet\sdk\5.0.200-preview.20601.7\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets(28,5): warning NETSDK1138: The target framework 'netcoreapp3.0' is out of support and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [C:\git\playground\coverlet\Example\Example.Test\Example.Test.csproj]
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
  Example.Core -> C:\git\playground\coverlet\Example\Example.Core\bin\Debug\netstandard2.0\Example.Core.dll
  Example.Test -> C:\git\playground\coverlet\Example\Example.Test\bin\Debug\netcoreapp3.0\Example.Test.dll
C:\Users\mrossignoli\.nuget\packages\coverlet.msbuild\3.0.0-preview.18.g183cbed8a6\build\coverlet.msbuild.targets(39,5): warning : [coverlet] Unable to instrument module: C:\git\playground\coverlet\Example\Example.Test\bin\Debug\netcoreapp3.0\System.ComponentModel.Annotations.dll because : No symbol found for file: C:\git\playground\coverlet\Example\Example.Test\bin\Debug\netcoreapp3.0\System.ComponentModel.Annotations.dll [C:\git\playground\coverlet\Example\Example.Test\Example.Test.csproj]
Test run for C:\git\playground\coverlet\Example\Example.Test\bin\Debug\netcoreapp3.0\Example.Test.dll (.NETCoreApp,Version=v3.0)
Microsoft (R) Test Execution Command Line Tool Version 16.9.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:     1, Skipped:     0, Total:     1, Duration: 114 ms - Example.Test.dll (netcoreapp3.0)

Calculating coverage result...
  Generating report 'C:\git\playground\coverlet\Example\Example.Test\coverage.json'

+--------------+------+--------+--------+
| Module       | Line | Branch | Method |
+--------------+------+--------+--------+
| Example.Core | 100% | 100%   | 100%   |
+--------------+------+--------+--------+

+---------+------+--------+--------+
|         | Line | Branch | Method |
+---------+------+--------+--------+
| Total   | 100% | 100%   | 100%   |
+---------+------+--------+--------+
| Average | 100% | 100%   | 100%   |
+---------+------+--------+--------+

Can you try with nightly and confirm? https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md version

<PackageReference Include="coverlet.msbuild" Version="3.0.0-preview.18.g183cbed8a6">
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>

[ming-tsai]

Hi @MarcoRossignoli,
So should I wait for 3.0.0?

[MarcoRossignoli]

Yep, btw a double check could help to be sure of it and close this, release is very close.

[ming-tsai]

Thanks guys, it is work