-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty results when generating coverage for Stripe.net #205
Comments
Hi @ob-stripe, will try to reproduce it. I should mention that coverlet works this way when running without |
Ah, good to know @tonerdo -- I'll focus on trying to fix this error then. |
I was able to successfully generate coverage by adding a |
Okay, I'm closing the issue since I was able to successfully compute coverage with a more recent version target. Thanks @tonerdo! |
@ob-stripe glad to hear that you figured it out. I don't think Coverlet works with any runtime version less than |
Hi! I'm one of the maintainers of the Stripe.net library and I'm trying to add coverlet to our test pipeline. However, I can only seem to get empty results.
The test projects has two different targets
netcoreapp1.1
andnet452
. I'm focusing onnetcoreapp1.1
at the moment since my dev environment is .NET Core on a Macbook:If I run with
--no-build
, all tests fail with:I'm not too sure what's that about, or if it's even related to the issue at hand.
I've looked at #188 which seemed like a similar issue, but our library doesn't use embedded PDBs -- there is no
<DebugType>
tag in the main project's.csproj
, so it uses the default which isportable
for .NET Core projects. I've also tried explicitly adding<DebugType>portable</DebugType>
but it doesn't change anything.If you want to try and reproduce, you can pull this branch: https://github.com/stripe/stripe-dotnet/tree/ob-coverage.
Any help would be greatly appreciated!
The text was updated successfully, but these errors were encountered: