Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create method in CatalogSource and PushSource (LENS-874) #35

Merged
merged 11 commits into from
Jun 2, 2023
Merged

feat: add create method in CatalogSource and PushSource (LENS-874) #35

merged 11 commits into from
Jun 2, 2023

Conversation

hdhayneCoveo
Copy link
Contributor

@hdhayneCoveo hdhayneCoveo commented May 30, 2023 •
edited
Loading

in this PR , i created a new static method to create a new Catalog Source in Coveo org

@hdhayneCoveo hdhayneCoveo requested a review from a team as a code owner May 30, 2023 21:03
@hdhayneCoveo hdhayneCoveo requested review from olamothe, y-lakhdar and btaillon-coveo and removed request for a team May 30, 2023 21:03
@github-actions
Copy link

github-actions bot commented May 30, 2023 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

y-lakhdar
y-lakhdar approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I just included additional info in some function documentation

src/main/java/com/coveo/pushapiclient/CatalogSource.java Outdated Show resolved Hide resolved
src/main/java/com/coveo/pushapiclient/CatalogSource.java Outdated Show resolved Hide resolved
src/main/java/com/coveo/pushapiclient/CatalogSource.java Outdated Show resolved Hide resolved
src/main/java/com/coveo/pushapiclient/PlatformClient.java Outdated Show resolved Hide resolved
src/main/java/com/coveo/pushapiclient/PushSource.java Outdated Show resolved Hide resolved
hdhayneCoveo and others added 8 commits June 1, 2023 10:22
@y-lakhdar y-lakhdar changed the title LENS-874 add create method in CatalogSource and PushSource feat: add create method in CatalogSource and PushSource (LENS-874) Jun 2, 2023
@hdhayneCoveo hdhayneCoveo merged commit aa3335c into main Jun 2, 2023
@hdhayneCoveo hdhayneCoveo deleted the LENS-874 branch June 2, 2023 17:51
@developer-experience-bot developer-experience-bot bot mentioned this pull request Jun 19, 2023
Closed
y-lakhdar pushed a commit that referenced this pull request Jun 20, 2023
@hdhayneCoveo @y-lakhdar
feat: add create method in CatalogSource and PushSource (LENS-874) (
f2e93a2 
#35)
@developer-experience-bot developer-experience-bot bot mentioned this pull request Jun 20, 2023
Merged
@developer-experience-bot developer-experience-bot bot mentioned this pull request Feb 8, 2024
Merged
@developer-experience-bot developer-experience-bot bot mentioned this pull request Apr 30, 2024
Closed
@developer-experience-bot developer-experience-bot bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@btaillon-coveo btaillon-coveo Awaiting requested review from btaillon-coveo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hdhayneCoveo @y-lakhdar @btaillon-coveo