-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LENS-1466): add support for partial updates in the UpdateStreamService #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwatkincoveo
requested review from
olamothe,
y-lakhdar and
fbeaudoincoveo
and removed request for
a team
March 20, 2024 15:11
jgwatkincoveo
changed the title
LENS-1466 Added partial update support for update streaming service
feat(LENS-1466): add support for partial updates in the UpdateStreamService
Mar 20, 2024
samisayegh
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🙌
src/test/java/com/coveo/pushapiclient/UpdateStreamServiceInternalTest.java
Show resolved
Hide resolved
src/main/java/com/coveo/pushapiclient/PartialUpdateDocument.java
Outdated
Show resolved
Hide resolved
sallainCoveo
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
src/test/java/com/coveo/pushapiclient/PartialUpdateDocumentTest.java
Outdated
Show resolved
Hide resolved
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LENS-1466
Added the capability of pushing the
partialUpdate
object in theUpdateStreamService
. See Dictionary field updateTesting
Update the catalog using the SDK
This resulted in the following data
After using the sdk with the following to update
We get the following updated in the admin UI