Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mantine): make EllipsisText tooltipProps prop optional #3935

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix(mantine): make EllipsisText tooltipProps prop optional #3935

merged 1 commit into from
Oct 23, 2024

Conversation

gdostie
Copy link
Collaborator

@gdostie gdostie commented Oct 23, 2024

Proposed Changes

Little woopsie

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@github-actions GitHub Actions
Copy link

✔️ Live demo of your latest successful build available here.

@gdostie gdostie marked this pull request as ready for review October 23, 2024 19:23
@gdostie gdostie requested a review from a team as a code owner October 23, 2024 19:23
@gdostie gdostie requested review from GermainBergeron and FelixBlaisThon and removed request for a team October 23, 2024 19:23
@gdostie gdostie merged commit 528a565 into master Oct 23, 2024
6 checks passed
@gdostie gdostie deleted the ADUI-10310-fix-EllipsisText-props branch October 23, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixBlaisThon FelixBlaisThon FelixBlaisThon approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdostie @GermainBergeron @FelixBlaisThon