Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add light preview #254

Merged
merged 99 commits into from
Jun 15, 2021
Merged

feat: add light preview #254

merged 99 commits into from
Jun 15, 2021

Conversation

y-lakhdar
Copy link
Contributor

@y-lakhdar y-lakhdar commented Jun 9, 2021 •
edited
Loading

Proposed changes

Show snapshot preview in the console.

Example of a snapshot that is not in sync with the target org
image

Exemple of a valid snapshot
image

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

Blocked by

CDX-346

y-lakhdar added 30 commits May 28, 2021 08:36
@y-lakhdar
use archiver to zip resources
f5ede26 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
updated readme
2b5fff3 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
add base classes
c0e746f 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
move project file
c5cb8fc 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
update import location
14d1c9b 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
add UT to Project class
dbe2ffb 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
add UT to snapshot class
697e538 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
apply corrections
d409ad4 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
setup snapshot factory
b272c59 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
snapshot class squeleton
4c04026 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
revert readme
d23326c 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
lock
fbced1e 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
format readme
9d9f5b3 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
fix conflicts
be2810c 
https://coveord.atlassian.net/browse/CDX-353
@y-lakhdar
allow the creation of a custom authenticated client
0ca9f69 
https://coveord.atlassian.net/browse/CDX-356
@y-lakhdar
push to organization
2859c6f 
https://coveord.atlassian.net/browse/CDX-356
@y-lakhdar
push a snapshot
804a195 
https://coveord.atlassian.net/browse/CDX-358
@y-lakhdar
add TODO
96d1da2 
https://coveord.atlassian.net/browse/CDX-358
@y-lakhdar
remove unecessary check
fe57a94 
https://coveord.atlassian.net/browse/CDX-358
@y-lakhdar
add public keyword
9f2577a 
https://coveord.atlassian.net/browse/CDX-358
@y-lakhdar
add patch to get detailed report
506d15e 
https://coveord.atlassian.net/browse/CDX-358
@y-lakhdar
remove any
1643f91 
https://coveord.atlassian.net/browse/CDX-358
@y-lakhdar
set static
c7a1109 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
add TODO
8b50867 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
better comment
7dfd9dd 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
fix type
98ffda6 
https://coveord.atlassian.net/browse/CDX-360
@y-lakhdar
Merge branch 'master' into CDX-360
d2f4c47
@y-lakhdar
Merge branch 'master' into CDX-360
e6d7087
@y-lakhdar
Merge branch 'CDX-360' of https://github.com/coveo/cli into CDX-353
eac47f5
@y-lakhdar
clean test
0f9d91a 
https://coveord.atlassian.net/browse/CDX-353
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

louis-bompart
louis-bompart previously requested changes Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would simplify the trimedStdout, other than that 👍

packages/cli/src/lib/snapshot/reportViewer.spec.ts Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.spec.ts Show resolved Hide resolved
@louis-bompart louis-bompart self-requested a review June 10, 2021 19:31
@y-lakhdar y-lakhdar marked this pull request as ready for review June 11, 2021 01:50
@y-lakhdar y-lakhdar requested a review from olamothe as a code owner June 11, 2021 01:50
olamothe
olamothe approved these changes Jun 11, 2021
View reviewed changes
packages/cli/src/commands/org/config/preview.spec.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.ts Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.ts Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.ts Outdated Show resolved Hide resolved
packages/cli/src/lib/snapshot/reportViewer.ts Outdated Show resolved Hide resolved
@y-lakhdar y-lakhdar dismissed louis-bompart’s stale review June 11, 2021 18:36

as discussed in slack, no need to worry about the trimmedStdout in the UT

@y-lakhdar y-lakhdar merged commit 3269a59 into master Jun 15, 2021
@louis-bompart louis-bompart deleted the CDX-346 branch July 29, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe olamothe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-lakhdar @olamothe @louis-bompart