Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): prevent d.ts files from being copied to project #135

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

y-lakhdar
Copy link
Contributor

This only happens when testing the schematic locally without going through the one published in npm.

https://coveord.atlassian.net/browse/CDX-221

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@louis-bompart louis-bompart merged commit 44cae70 into master Apr 7, 2021
y-lakhdar added a commit that referenced this pull request Apr 7, 2021
…ile is invalid" (#138)

* fix(angular): prevent d.ts files from being copied to project (#135)

https://coveord.atlassian.net/browse/CDX-221

* Revert "feat(angular): redirect user to an error page if the `.env` file is invalid (#137)"

This reverts commit 130fcfb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants