Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): fix jenkins artifacting #988

Merged
merged 6 commits into from
Oct 18, 2022
Merged

chore(release): fix jenkins artifacting #988

merged 6 commits into from
Oct 18, 2022

Conversation

louis-bompart
Copy link
Collaborator

Proposed changes

  • Fix ESM import (need file-ext)
  • Recover tag from release (simpler)
  • Infer file architecture from filename instead of 'redoing' oclif logic

Testing

  • Manual Tests: Created a PAT and run it on my machine, checked the artifacts folder.

@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart merged commit 8685b37 into master Oct 18, 2022
@louis-bompart louis-bompart deleted the fix-jenkins branch October 18, 2022 19:06
@louis-bompart louis-bompart mentioned this pull request Nov 15, 2022
Merged
1 task
louis-bompart added a commit that referenced this pull request Nov 17, 2022
@louis-bompart
fix(cli): fix sha acquisiton for windows signing (#1031)
dcc3131 
<!-- For Coveo Employees only. Fill this section.

CDX-1230

-->

## Proposed changes
Similar problem and similar fix as #988

## Testing

- [x] Manual Tests: Replicated file tree and ran the script. Assessed
the hash was there and complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-lakhdar y-lakhdar y-lakhdar approved these changes

@olamothe olamothe Awaiting requested review from olamothe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-bompart @y-lakhdar