Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): ensure user is webauth-ed for ui cmds #963

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Sep 29, 2022

https://coveord.atlassian.net/browse/CDX-1192

Proposed changes

Add a precondition to ensure that the user authenticated using the OAuth flow and not an API Key for the ui:create commands.

Testing

  • Unit Tests

@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDX-1992 does not seem like a valid ticket. I'm lacking some context as to why this is needed.

@louis-bompart louis-bompart force-pushed the CDX-1992 branch 2 times, most recently from 186fdd1 to a73ad56 Compare October 3, 2022 21:08
@louis-bompart louis-bompart marked this pull request as draft October 4, 2022 01:27
@louis-bompart
Copy link
Collaborator Author

Back to draft, big refactor/tests clean up I'll need to sort out from this branch

@louis-bompart louis-bompart force-pushed the CDX-1992 branch 3 times, most recently from b063237 to 70d4669 Compare October 4, 2022 20:33
@louis-bompart louis-bompart changed the base branch from master to test-source-overhaul October 4, 2022 20:41
@louis-bompart louis-bompart marked this pull request as ready for review October 4, 2022 20:42
@louis-bompart louis-bompart requested a review from olamothe October 4, 2022 20:42
@louis-bompart louis-bompart force-pushed the CDX-1992 branch 3 times, most recently from b927346 to b715043 Compare October 5, 2022 04:13
Base automatically changed from test-source-overhaul to master October 13, 2022 18:35
@louis-bompart louis-bompart merged commit 2a0840c into master Oct 13, 2022
@louis-bompart louis-bompart deleted the CDX-1992 branch October 13, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants