fix(dump): remove recursion #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @louis-bompart !
|
louis-bompart
force-pushed
the
fix/dump-recursion-bug
branch
from
8539697 to
d7cf894
Compare
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
louis-bompart
force-pushed
the
fix/dump-recursion-bug
branch
from
d7cf894 to
60d6593
Compare
louis-bompart
commented
Aug 18, 2022
|
y-lakhdar
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDX-1117
Proposed changes
This is often due to recursion that goes too far.
The only recursion in the search dump is the one removed in this PR.
Testing
Corner case, so no automated tests.
@coveo/[email protected]was released as alpha for validation on customer organization by support. waiting for confirmation from them.