-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): always track #870
Conversation
Thanks for your contribution @louis-bompart !
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure that I see a condition that blocks tracking if the user is not logged in, will that be in this PR? Correct me if I'm wrong, it's my first time roaming around in this code
Good catch. Most commands require user to be logged in both some few can be executed without being logged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only track when user is logged in.
cli/packages/cli/src/hooks/analytics/analytics.ts Lines 18 to 21 in d81ffb0
|
Proposed changes
Testing
Footnotes
technically still possible by having CI=true in your env var ↩