Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): remove persistent analytics identifers #869

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

louis-bompart
Copy link
Collaborator

Proposed changes

Removed persistent identifiers, such as the session id. Instead, Amplitude will manage to find whos whos using the other informations

Testing

  • Unit Tests

@louis-bompart louis-bompart enabled auto-merge (squash) July 21, 2022 15:10
@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@louis-bompart louis-bompart requested a review from tcamire July 21, 2022 15:10
@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Copy link

@tcamire tcamire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! This should really not affect session tracking, but I'll test it in dev once its merged to make sure its ok

@louis-bompart louis-bompart merged commit 236cf0f into master Jul 21, 2022
@louis-bompart louis-bompart deleted the feat/CDX-1081 branch July 21, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants