Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly support --snapshotId flag #866

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: correctly support --snapshotId flag #866

merged 1 commit into from
Jul 21, 2022

Conversation

y-lakhdar
Copy link
Contributor

https://coveord.atlassian.net/browse/CDX-1078

Proposed changes

  • Enable preview for existing snapshot
  • Make sure to not delete the snapshot if it was already present in the organzation

Testing

  • Unit Tests:
  • Functionnal Tests:
  • Manual Tests:

@github-actions
Copy link
Contributor

Thanks for your contribution @y-lakhdar !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@y-lakhdar y-lakhdar merged commit ec9344f into master Jul 21, 2022
@y-lakhdar y-lakhdar deleted the CDX-1078 branch July 21, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-bompart louis-bompart louis-bompart approved these changes

@olamothe olamothe Awaiting requested review from olamothe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y-lakhdar @louis-bompart