Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot): ignore error if file is already unexisting #833

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

louis-bompart
Copy link
Collaborator

https://coveord.atlassian.net/browse/CDX-926

Proposed changes

The error was occurring on rmSync because the file was missing. We don't really care that it's not there, so we just have to ignore the error using force: true, which silences the error.

Testing

  • Unit Tests:
  • Manual Tests:

@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart merged commit e2711f3 into master Jun 13, 2022
@louis-bompart louis-bompart deleted the CDX-926 branch June 13, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants