Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): remove create-atomic-template from the dependencies #809

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented May 31, 2022

https://coveord.atlassian.net/browse/CDX-1015

Proposed changes

The latest change tried to install the private package @coveo/create-atomic-template. It should not.

  • Removed the package from the dep of create-atomic
  • Ensured it won't do it again by tweaking the release script.

Testing

  • Manual Tests:
    Did check the loop:
    • @coveo/create-atomic-template is filtered out for atomic when running the script in the context of create-atomic
    • @coveo/create-atomic is not filtered out when running the script in the context of cli

@github-actions
Copy link
Contributor

Thanks for your contribution @louis-bompart !
When your pull-request is ready to be merged, check the box below to merge it

  • Merge! :shipit:

@github-actions
Copy link
Contributor

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

@louis-bompart louis-bompart merged commit dccc5b1 into master Jun 2, 2022
@louis-bompart louis-bompart deleted the CDX-1015 branch June 2, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants